nw-review-workflow
Detailed review process, v2 validation checklist, and scoring methodology for agent definition reviews
它会碰到什么
这一栏是扫描器报的事实,不是结论。命中多不等于有毒(安全工具、规则库、示例脚本本来就会包含危险写法),命中少也不等于干净。它和你手上的凭据、文件、网络有什么关系,需要你自己看。
技能内容
Agent Review Workflow
V2 Validation Checklist (11 Points)
Run against every agent under review. Each item pass/fail.
- Frontmatter format:
---delimited YAML withnameanddescription - Size compliance: Under 400 lines; domain knowledge in Skills
- Divergence-only: Only behaviors diverging from Claude defaults
- Calm language: No "CRITICAL", "MANDATORY", "ABSOLUTE"
- Examples present: 3-5 canonical for critical/subtle behaviors
- Least privilege tools: Minimum needed in frontmatter
- maxTurns set: Present in frontmatter
- Platform safety: Via frontmatter/hooks, not prose
- Affirmative phrasing: "Do X" not "Don't do Y"
- Consistent terminology: One term per concept
- Clear delegation: Description states when to delegate
Scoring Methodology
Per-Dimension Scoring
For each of 7 critique dimensions (from critique-dimensions skill):
- Pass: All checks satisfied
- Fail: One or more checks not satisfied
Verdict Logic
IF any high-severity dimension fails:
verdict = "revisions_needed"
ELIF count(medium-severity failures) >= 3:
verdict = "revisions_needed"
ELSE:
verdict = "approved"
High-severity: template_compliance, size_and_focus, safety_implementation, priority_validation
Medium-severity: divergence_quality, language_and_tone, examples_quality
Evidence Requirements
Every finding includes: Dimension (which of 7) | Severity (high/medium/low) | Finding (observed, with line numbers/counts) | Recommendation (specific fix action)
Common V1 to V2 Migration Issues
| Residual Pattern | What to Flag |
|-----------------|-------------|
| Embedded YAML config blocks | Should be frontmatter or removed |
| activation-instructions section | Remove -- Claude Code handles activation |
| IDE-FILE-RESOLUTION section | Remove -- not needed in v2 |
| commands with 10+ entries | Reduce to 3-5 focused |
| Inline embed_knowledge | Extract to Skills |
| 5+ "production frameworks" | Remove -- platform handles safety |
| CRITICAL: prefixed instructions | Rephrase as calm direct statements |
| Python/YAML safety code examples | Remove -- aspirational, not executable |
Peer Review Protocol
- Receive agent file path from builder
- Execute full dimension review
- Return structured YAML verdict
- If
revisions_needed, include prioritized fix list - Builder revises and resubmits (max 2 iterations)
- On second rejection, escalate to user
Command Template Review
Additional checks for nWave command files (tasks):
- Size: 50-60 lines target; >60 warning, >150 major, >500 blocker
- Structure: agent activation metadata, context files section, success criteria
- Delegation: business logic belongs in agent, not command
- No embedded procedural steps (STEP 1, STEP 2)
想直接用这个技能?
本站把开放许可(MIT / Apache 等)的技能按仓库打包整理到网盘,点一下转存到你自己的网盘,不用一个个从 GitHub 拉。许可未声明的技能只给原始仓库链接,不打包。
同名技能的其他版本
有 2 个不同仓库或目录里都有叫 nw-review-workflow 的技能。它们内容并不相同,别混用:
- nWave-ai/nWave — Detailed review process, v2 validation checklist, and scoring methodology for agent defini