跳到主要内容
知仓学习社ZHICANG

pr-review-expert

>

读凭据读文件严重 8 · 高危 0borghei/Claude-Skills

它会碰到什么

扫了多少7 个文本文件,60 KB
它会碰到什么读凭据读文件
命中总数12 处
命中统计严重 8 · 高 0 · 中 3 · 低 0
逐条看命中(8 条严重或高危)
  • 严重 references/review-workflow-commands.md:108cred-paths
    grep "^-" $DIFF | grep -oE "process\.env\.[A-Z_]+" | sort -u
  • 严重 references/review-workflow-commands.md:111cred-paths
    grep "^+" $DIFF | grep -oE "process\.env\.[A-Z_]+" | sort -u
  • 严重 references/writeup-format-and-checklist.md:39cred-paths
    **4. New env var `FEATURE_FLAG_X` not in `.env.example`**
  • 严重 references/writeup-format-and-checklist.md:40cred-paths
    Add to `.env.example` with description so other developers know about it.
  • 严重 references/writeup-format-and-checklist.md:72cred-paths
    - [ ] New env vars documented in .env.example
  • 严重 scripts/diff_analyzer.py:25cred-paths
    (r"(^|/)\.env", "Environment config file", "HIGH"),
  • 严重 scripts/diff_analyzer.py:44cred-paths
    r"\.conf$", r"\.env", r"Makefile$", r"\.lock$",
  • 严重 scripts/review_checklist_generator.py:145cred-paths
    ("breaking", "New environment variables documented in .env.example"),

这一栏是扫描器报的事实,不是结论。命中多不等于有毒(安全工具、规则库、示例脚本本来就会包含危险写法),命中少也不等于干净。它和你手上的凭据、文件、网络有什么关系,需要你自己看。

技能内容

PR Review Expert

Structured, systematic code review for GitHub PRs and GitLab MRs. Goes beyond style nits to perform blast-radius analysis, security vulnerability scanning, breaking-change detection, test-coverage delta calculation, and performance impact assessment. Produces reviewer-ready reports with prioritized findings categorized as must-fix, should-fix, and suggestions.

Keywords: PR review, code review, pull request, merge request, blast radius, security scan, breaking changes, test coverage, review checklist, code quality

Core Capabilities

  • Blast radius analysis — trace which files, services, and downstream consumers a diff could break; quantify severity CRITICAL/HIGH/MEDIUM/LOW.
  • Security scanning — detect SQL injection, XSS vectors, hardcoded secrets, auth bypass, insecure crypto, path traversal, and prototype pollution in the diff.
  • Breaking-change detection — flag API removals/renames, response-schema and required-field changes, DB column removals, env-var changes, and TS interface edits.
  • Test coverage analysis — new-code vs new-test ratio, missing tests for new public functions, deleted tests without deleted code, coverage delta.
  • Performance assessment — N+1 query patterns, bundle-size regressions, unbounded queries, missing indexes.
  • Reviewer-ready output — prioritized must-fix / should-fix / suggestion report, a 35-item checklist, and consistent comment labels.

When to Use

  • Before merging any PR that touches shared libraries, APIs, or database schemas.
  • When a PR is large (>200 lines changed) and needs structured review.
  • For PRs in security-sensitive code paths (auth, payments, PII handling).
  • After an incident, to proactively review similar code changes.
  • For onboarding new contributors whose PRs need thorough feedback.

Tools

| Tool | Purpose | Command |

|------|---------|---------|

| blast_radius_calculator.py | Calculate PR blast radius from import chains / dependency trees of changed files | git diff --name-only main...HEAD \| python scripts/blast_radius_calculator.py --root src |

| diff_analyzer.py | Analyze a diff for risk indicators (large files, sensitive paths, config/breaking/security patterns) | gh pr diff $PR \| python scripts/diff_analyzer.py --json |

| review_checklist_generator.py | Generate a tailored review checklist from changed file types/patterns | git diff --name-only main...HEAD \| python scripts/review_checklist_generator.py |

References

Load the reference that matches the task — keep this file lean and pull detail on demand:

  • [references/review-workflow-commands.md](references/review-workflow-commands.md) — the 6-step review workflow with the exact gh/grep command catalog for context gathering, blast radius, security scan, breaking-change detection, coverage delta, and performance impact (plus the blast-radius severity table and coverage rules). Read when actually performing a review.
  • [references/writeup-format-and-checklist.md](references/writeup-format-and-checklist.md) — the review report template with worked examples, the complete 35-item review checklist, and the comment-label taxonomy. Read when writing up findings.
  • [references/best-practices-and-troubleshooting.md](references/best-practices-and-troubleshooting.md) — common reviewer pitfalls, best-practice habits, the troubleshooting table, and the success-criteria bar. Read before and after a review for quality control.

Scope & Limitations

This skill covers:

  • Structured review of GitHub PRs and GitLab MRs using a 35+ item checklist
  • Blast radius analysis for monorepo and multi-service architectures
  • Static security scanning of diffs for common vulnerability patterns (SQLi, XSS, secrets, auth bypass)
  • Breaking change detection for APIs, database schemas, TypeScript interfaces, and environment variables

This skill does NOT cover:

  • Automated code fixes or refactoring — use engineering/saas-scaffolder or engineering/migration-architect for code generation
  • Runtime security analysis, SAST/DAST tool orchestration, or CVE database lookups — use engineering/dependency-auditor for dependency-level vulnerability scanning
  • CI/CD pipeline configuration or build failure triage — use engineering/ci-cd-pipeline-builder for pipeline design
  • Performance benchmarking or load testing — use engineering/performance-profiler for profiling and optimization guidance

Integration Points

| Skill | Integration | Data Flow |

|-------|-------------|-----------|

| engineering/dependency-auditor | Run dependency audit before reviewing PRs that add or upgrade packages | Audit report feeds into the Security section of the review report |

| engineering/ci-cd-pipeline-builder | Embed review checklist gates into CI pipelines as automated PR checks | Checklist items become pass/fail signals in the pipeline |

| engineering/performance-profiler | Escalate N+1 and unbounded query findings for detailed profiling | Flagged code paths from review become profiling targets |

| engineering/migration-architect | Validate database migration safety for PRs that include schema changes | Migration risk assessment supplements the Breaking Changes section |

| engineering/release-manager | Feed breaking change detection results into release notes and changelogs | Detected breaking changes auto-populate release documentation |

| engineering/api-design-reviewer | Cross-reference API endpoint changes with API design standards | API review findings merge into the Blast Radius and Breaking Changes sections |

想直接用这个技能?

本站把开放许可(MIT / Apache 等)的技能按仓库打包整理到网盘,点一下转存到你自己的网盘,不用一个个从 GitHub 拉。许可未声明的技能只给原始仓库链接,不打包。